Skip to content

fix(@angular-devkit/build-angular): add node_modules prefix to excludes RegExp#22917

Merged
alan-agius4 merged 1 commit intoangular:masterfrom
alan-agius4:webpack-project-name
Mar 30, 2022
Merged

fix(@angular-devkit/build-angular): add node_modules prefix to excludes RegExp#22917
alan-agius4 merged 1 commit intoangular:masterfrom
alan-agius4:webpack-project-name

Conversation

@alan-agius4
Copy link
Collaborator

Without the node_modules prefix, projects named the same as the excluded package names ex: webpack will not compile successfully as all files under the mentioned project will be excluded from being requested by the respective loaders.

Closes #22902

…udes RegExp

Without the `node_modules` prefix, projects named the same as the excluded package names ex: `webpack` will not compile successfully as all files under the mentioned project will be excluded from being requested by the respective loaders.

Closes #22902
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Mar 30, 2022
@alan-agius4 alan-agius4 requested a review from clydin March 30, 2022 15:15
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 30, 2022
@alan-agius4 alan-agius4 merged commit 371da23 into angular:master Mar 30, 2022
@alan-agius4 alan-agius4 deleted the webpack-project-name branch March 30, 2022 15:46
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ng test/build fail after "ng new" with project name "webpack"

2 participants