fix(@angular-devkit/build-webpack): correctly handle ESM webpack configurations#22553
Merged
alan-agius4 merged 2 commits intoangular:masterfrom Jan 24, 2022
alan-agius4:esm-config-webpack
Merged
fix(@angular-devkit/build-webpack): correctly handle ESM webpack configurations#22553alan-agius4 merged 2 commits intoangular:masterfrom alan-agius4:esm-config-webpack
alan-agius4 merged 2 commits intoangular:masterfrom
alan-agius4:esm-config-webpack
Conversation
|
nice work <3 @alan-agius4 |
…igurations Previoiusly, we didn't correctly handle ESM configurations as the `import` was always downlevelled to `require` by TypeScript. Closes #22547
This was referenced Jan 24, 2022
|
@alan-agius4 I believe this will require the same treatment (if any of the builders is ESM itself). |
dgp1130
approved these changes
Jan 24, 2022
Previoiusly, we didn't correctly handle ESM builders as the `import` was always downlevelled to `require` by TypeScript.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previoiusly, we didn't correctly handle ESM configurations as the
importwas always downlevelled torequireby TypeScript.Closes #22547