fix(@angular-devkit/build-angular): lazy modules bundle budgets#22239
Merged
dgp1130 merged 2 commits intoangular:masterfrom Nov 29, 2021
alan-agius4:bundle-budgets-lazy-loading
Merged
fix(@angular-devkit/build-angular): lazy modules bundle budgets#22239dgp1130 merged 2 commits intoangular:masterfrom alan-agius4:bundle-budgets-lazy-loading
dgp1130 merged 2 commits intoangular:masterfrom
alan-agius4:bundle-budgets-lazy-loading
Conversation
…est to use new test harness With this change we replace the bundle budgets specs to use the new test harness.
Since the introduction of Webpack 5 in version 12 bundle budgets for lazy chunks have been broken due to the removal of the `NamedLazyChunksPlugin`. https://github.com/angular/angular-cli/blob/21a49e6492dda1c4a325c0339518c3c110880d02/packages/angular_devkit/build_angular/src/webpack/plugins/named-chunks-plugin.ts#L8 With this change we re-introduce a similar plugin to allow setting bundle budgets on lazy chunks. This issue has also been reported on Slack by a GDE https://angular-team.slack.com/archives/C08M4JKNH/p1637115196222300 Closes: #11019
dgp1130
approved these changes
Nov 29, 2021
Collaborator
|
@alan-agius4, this had a merge conflict with |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the introduction of Webpack 5 in version 12 bundle budgets for lazy chunks have been broken due to the removal of the
NamedLazyChunksPlugin.angular-cli/packages/angular_devkit/build_angular/src/webpack/plugins/named-chunks-plugin.ts
Line 8 in 21a49e6
With this change we re-introduce a similar plugin to allow setting bundle budgets on lazy chunks.
This issue has also been reported on Slack by a GDE https://angular-team.slack.com/archives/C08M4JKNH/p1637115196222300
Closes: #11019