I feel that I will need some extra guidance on this one :) @alan-agius4 @petebacondarwin @alxhub your advice/feedback would be very appreciated.

Duplicate and missing translations are handled differently, and it makes sense:

• duplicate translations can be identified during loading
• missing translations can be identified only during inlining

To handle missing translations Diagnostics are used and there is single place which register them: https://github.com/angular/angular/blob/master/packages/localize/tools/src/source_file_utils.ts#L379

Meanwhile, duplicate translation handling (or loading of translations itself) is duplicated (pun intended):

• There is TranslationsLoader in @angular/localize with Diagnostics (deprecated?) based duplicate translations handling: https://github.com/angular/angular/blob/master/packages/localize/tools/src/translate/translation_files/translation_loader.ts#L126
• and there similar TranslationsLoader in @angular/angular-cli with different (not based on Diagnostics) handling of duplicate translations: https://github.com/angular/angular-cli/blob/master/packages/angular_devkit/build_angular/src/utils/i18n-options.ts#L254

Couple of questions:

• Should TranslationsLoader from @angular/localize be used in CLI?
• If not, should handling of duplicate translations in @angular/angular-cli be based on Diagnostics?
• Should I18NTranslation (used to be I18NMissingTranslation) somehow point to DiagnosticHandlingStrategy instead?

Hi @minijus,

Sorry for taking so long to get back to you.

Should TranslationsLoader from @angular/localize be used in CLI?

If that is possible, sure! But, I suspect it's not as straightforward.

If not, should handling of duplicate translations in @angular/angular-cli be based on Diagnostics?

If not, I assume that we can just change the warn here to either be ignored or changed to error.

Should I18NTranslation (used to be I18NMissingTranslation) somehow point to DiagnosticHandlingStrategy instead?

I18NTranslation is generated from a JSON schema and there is no good way that this can be replaced with an import to DiagnosticHandlingStrategy

@minijus, is this something that you still want to spear head?

@minijus, is this something that you still want to spear head?

@alan-agius4 - yes, absolutely. We have a custom extract-i18n builder which splits translations per libs/projects and when building such applications the output is trashed with warnings about duplicate tranaslations. So, I am very much interested/motivated to "fix" it. And the classic part now, "just have not found enough time during last week" :)

I can close this draft PR and open it once it is ready for review if you want to keep PR list clean.

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}