Skip to content

feat(@schematics/angular): use es2015 modules overall#11196

Merged
filipesilva merged 1 commit intoangular:masterfrom
filipesilva:es2015-test
Jun 13, 2018
Merged

feat(@schematics/angular): use es2015 modules overall#11196
filipesilva merged 1 commit intoangular:masterfrom
filipesilva:es2015-test

Conversation

@filipesilva
Copy link
Copy Markdown
Contributor

This change helps to keep the behaviour of build/serve/test consistent by using the same import semantics in all of them.

@mgol
Copy link
Copy Markdown
Member

mgol commented Jun 11, 2018

Something to check: what about tsconfig.server.json when Universal is used? Will it still work correctly with "module": "es2015"?

@filipesilva filipesilva changed the title feat(@schematics/angular): use es2015 modules in app and test feat(@schematics/angular): use es2015 modules overall Jun 11, 2018
@filipesilva filipesilva force-pushed the es2015-test branch 2 times, most recently from 69b415c to a366487 Compare June 13, 2018 15:58
@filipesilva
Copy link
Copy Markdown
Contributor Author

@mgol good catch, added now.

This change helps to keep the behaviour of build/serve/test consistent by using the same import semantics in all of them.
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants