fix(@angular-devkit/core): when two projects are the same, pick the first declared

hansl · filipesilva · commit e52e0e1fc8dc · 2018-06-13T22:40:11.000+01:00
The comparator function for project names was invalid; sort() expect to be consistent and
in this case was returning 1 for a set of arguments, and 0 if arguments were reversed, leading
inconsistencies in the sort result.
diff --git a/packages/angular_devkit/core/src/workspace/workspace.ts b/packages/angular_devkit/core/src/workspace/workspace.ts
@@ -170,8 +170,10 @@ export class Workspace {
     const projects = this.listProjectNames()
       .map(name => [this.getProject(name).root, name] as [Path, string])
       .filter(tuple => isInside(tuple[0], path))
-      // Sort tuples by depth, with the deeper ones first.
-      .sort((a, b) => isInside(a[0], b[0]) ? 1 : 0);
+      // Sort tuples by depth, with the deeper ones first. Since the first member is a path and
+      // we filtered all invalid paths, the longest will be the deepest (and in case of equality
+      // the sort is stable and the first declared project will win).
+      .sort((a, b) => b[0].length - a[0].length);
 
     if (projects[0]) {
       return projects[0][1];
