fix(@angular-devkit/build-angular): replace dev-server socket path from /ws to /ng-cli-ws

alan-agius4 · dgp1130 · commit 9301699f7a0a · 2022-06-02T13:01:28.000-07:00
In some cases `/ws` caused conflicts with local websocket connections. Hence we change the dev-server web socket path to something more specific to the Angular CLI. Closes #23260
diff --git a/packages/angular_devkit/build_angular/src/builders/dev-server/specs/live-reload_spec.ts b/packages/angular_devkit/build_angular/src/builders/dev-server/specs/live-reload_spec.ts
@@ -95,7 +95,8 @@ function createProxy(target: string, secure: boolean, ws = true): ProxyInstance
 
 async function goToPageAndWaitForWS(page: Page, url: string): Promise<void> {
   const baseUrl = url.replace(/^http/, 'ws');
-  const socksRequest = baseUrl[baseUrl.length - 1] === '/' ? `${baseUrl}ws` : `${baseUrl}/ws`;
+  const socksRequest =
+    baseUrl[baseUrl.length - 1] === '/' ? `${baseUrl}ng-cli-ws` : `${baseUrl}/ng-cli-ws`;
   // Create a Chrome dev tools session so that we can capturing websocket request.
   // https://github.com/puppeteer/puppeteer/issues/2974
 
diff --git a/packages/angular_devkit/build_angular/src/webpack/configs/dev-server.ts b/packages/angular_devkit/build_angular/src/webpack/configs/dev-server.ts
@@ -298,7 +298,7 @@ function getWebSocketSettings(
     };
   }
 
-  const webSocketPath = posix.join(servePath, 'ws');
+  const webSocketPath = posix.join(servePath, 'ng-cli-ws');
 
   return {
     webSocketServer: {

Original file line number	Diff line number	Diff line change
`@@ -298,7 +298,7 @@ function getWebSocketSettings(`
`298`	`298`	`};`
`299`	`299`	`}`
`300`	`300`
`301`		`- const webSocketPath = posix.join(servePath, 'ws');`
	`301`	`+ const webSocketPath = posix.join(servePath, 'ng-cli-ws');`
`302`	`302`
`303`	`303`	`return {`
`304`	`304`	`webSocketServer: {`