test: don't run git clean on test failure

alan-agius4 · alan-agius4 · commit 6a8511d1f93b · 2022-09-09T17:51:11.000+02:00
This allows debugging the test failures when running in debug mode.

(cherry picked from commit e8e9df875722d23bbfd11c70ad17c492353976ce)
diff --git a/tests/legacy-cli/e2e_runner.ts b/tests/legacy-cli/e2e_runner.ts
@@ -250,37 +250,29 @@ async function runSteps(
   }
 }
 
-async function runSetup(absoluteName: string) {
+function runSetup(absoluteName: string): Promise<void> {
   const module = require(absoluteName);
 
-  await (typeof module === 'function' ? module : module.default)();
+  return (typeof module === 'function' ? module : module.default)();
 }
 
 /**
  * Run a file from the projects root directory in a subprocess via launchTestProcess().
  */
-async function runInitializer(absoluteName: string) {
+function runInitializer(absoluteName: string): Promise<void> {
   process.chdir(getGlobalVariable('projects-root'));
 
-  await launchTestProcess(absoluteName);
+  return launchTestProcess(absoluteName);
 }
 
 /**
  * Run a file from the main 'test-project' directory in a subprocess via launchTestProcess().
  */
-async function runTest(absoluteName: string) {
+async function runTest(absoluteName: string): Promise<void> {
   process.chdir(join(getGlobalVariable('projects-root'), 'test-project'));
 
-  try {
-    await launchTestProcess(absoluteName);
-  } finally {
-    logStack.push(new logging.NullLogger());
-    try {
-      await gitClean();
-    } finally {
-      logStack.pop();
-    }
-  }
+  await launchTestProcess(absoluteName);
+  await gitClean();
 }
 
 function printHeader(
