ci: configure bazel to ignore vite tests when using non esbuild tests

alan-agius4 · clydin · commit 5ec624e1195d · 2023-11-13T14:59:50.000-05:00
This commit configures bazel to skip adding vite tests to the webpack tests shards.
diff --git a/tests/legacy-cli/e2e.bzl b/tests/legacy-cli/e2e.bzl
@@ -38,6 +38,10 @@ ESBUILD_TESTS = [
     "tests/test/**",
 ]
 
+WEBPACK_IGNORE_TESTS = [
+    "tests/vite/**",
+]
+
 def _to_glob(patterns):
     if len(patterns) == 1:
         return patterns[0]
@@ -126,7 +130,7 @@ def _e2e_suite(name, runner, type, data, toolchain_name = "", toolchain = None):
     if type == "yarn":
         args.append("--yarn")
         tests = YARN_TESTS
-        ignore = BROWSER_TESTS
+        ignore = BROWSER_TESTS + WEBPACK_IGNORE_TESTS
     elif type == "esbuild":
         args.append("--esbuild")
         tests = ESBUILD_TESTS
@@ -137,7 +141,7 @@ def _e2e_suite(name, runner, type, data, toolchain_name = "", toolchain = None):
         ignore = None
     elif type == "npm":
         tests = None
-        ignore = BROWSER_TESTS
+        ignore = BROWSER_TESTS + WEBPACK_IGNORE_TESTS
 
     # Standard e2e tests
     _e2e_tests(
diff --git a/tests/legacy-cli/e2e/tests/vite/reuse-dep-optimization-cache.ts b/tests/legacy-cli/e2e/tests/vite/reuse-dep-optimization-cache.ts
@@ -2,14 +2,8 @@ import { setTimeout } from 'node:timers/promises';
 import assert from 'node:assert';
 import { findFreePort } from '../../utils/network';
 import { execAndWaitForOutputToMatch, killAllProcesses, ng } from '../../utils/process';
-import { getGlobalVariable } from '../../utils/env';
 
 export default async function () {
-  const useWebpackBuilder = !getGlobalVariable('argv')['esbuild'];
-  if (useWebpackBuilder) {
-    return;
-  }
-
   await ng('cache', 'clean');
   await ng('cache', 'on');
 
