fix(@angular-devkit/build-angular): percent encode asset URLs in development server for esbuild

clydin · alan-agius4 · commit 4c82bb8e812e · 2023-05-19T10:29:40.000+02:00
When using the esbuild-based browser application builder with the development server, configured
application assets are served directly from disk. The URLs passed to Vite are now percent encoded
to properly handle asset paths that may contain unsupported URL characters.
diff --git a/packages/angular_devkit/build_angular/src/builders/dev-server/vite-server.ts b/packages/angular_devkit/build_angular/src/builders/dev-server/vite-server.ts
@@ -255,7 +255,7 @@ export async function setupServer(
             // Parse the incoming request.
             // The base of the URL is unused but required to parse the URL.
             const parsedUrl = new URL(req.url, 'http://localhost');
-            let pathname = parsedUrl.pathname;
+            let pathname = decodeURIComponent(parsedUrl.pathname);
             if (serverOptions.servePath && pathname.startsWith(serverOptions.servePath)) {
               pathname = pathname.slice(serverOptions.servePath.length);
               if (pathname[0] !== '/') {
@@ -267,7 +267,7 @@ export async function setupServer(
             // Rewrite all build assets to a vite raw fs URL
             const assetSourcePath = assets.get(pathname);
             if (assetSourcePath !== undefined) {
-              req.url = `/@fs/${normalizePath(assetSourcePath)}`;
+              req.url = `/@fs/${encodeURIComponent(assetSourcePath)}`;
               next();
 
               return;
