fix(@angular-devkit/build-angular): keep esbuild server active until builder fully stops

clydin · angular-robot[bot] · commit 4822b3ba55ec · 2023-04-05T09:25:37.000Z
Use the now working builder teardown functionality to ensure that the development server
is properly closed when the builder is stopped.
diff --git a/packages/angular_devkit/build_angular/BUILD.bazel b/packages/angular_devkit/build_angular/BUILD.bazel
@@ -340,6 +340,7 @@ LARGE_SPECS = {
         ],
     },
     "browser-esbuild": {
+        "shards": 10,
         "extra_deps": [
             "@npm//buffer",
         ],
diff --git a/packages/angular_devkit/build_angular/src/builders/dev-server/vite-server.ts b/packages/angular_devkit/build_angular/src/builders/dev-server/vite-server.ts
@@ -148,7 +148,14 @@ export async function* serveWithVite(
     yield { success: true, port: listeningAddress?.port } as unknown as DevServerBuilderOutput;
   }
 
-  await server?.close();
+  if (server) {
+    let deferred: () => void;
+    context.addTeardown(async () => {
+      await server?.close();
+      deferred?.();
+    });
+    await new Promise<void>((resolve) => (deferred = resolve));
+  }
 }
 
 async function setupServer(

Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,14 @@ export async function* serveWithVite(`
`148`	`148`	`yield { success: true, port: listeningAddress?.port } as unknown as DevServerBuilderOutput;`
`149`	`149`	`}`
`150`	`150`
`151`		`- await server?.close();`
	`151`	`+ if (server) {`
	`152`	`+ let deferred: () => void;`
	`153`	`+ context.addTeardown(async () => {`
	`154`	`+ await server?.close();`
	`155`	`+ deferred?.();`
	`156`	`+ });`
	`157`	`+ await new Promise<void>((resolve) => (deferred = resolve));`
	`158`	`+ }`
`152`	`159`	`}`
`153`	`160`
`154`	`161`	`async function setupServer(`