fix(@angular-devkit/build-angular): ensure compilation errors propagate to all bundle actions

clydin · clydin · commit 38b7667ce35a · 2023-11-15T07:53:59.000-05:00
If the TypeScript and/or Angular AOT compiler fails to initialize or emit files due to an error,
the shared compilation state between the browser code bundle action and any additional bundle actions
(polyfills, server, etc.) will now carry an error flag to ensure that the additional bundle actions
bypass file emit. The file emit bypass is necessary in these cases to prevent an unintentional and
misleading error about a file not being included in the compilation.
diff --git a/packages/angular_devkit/build_angular/src/tools/esbuild/angular/compilation-state.ts b/packages/angular_devkit/build_angular/src/tools/esbuild/angular/compilation-state.ts
@@ -8,12 +8,13 @@
 
 export class SharedTSCompilationState {
   #pendingCompilation = true;
-  #resolveCompilationReady: (() => void) | undefined;
-  #compilationReadyPromise: Promise<void> | undefined;
+  #resolveCompilationReady: ((value: boolean) => void) | undefined;
+  #compilationReadyPromise: Promise<boolean> | undefined;
+  #hasErrors = true;
 
-  get waitUntilReady(): Promise<void> {
+  get waitUntilReady(): Promise<boolean> {
     if (!this.#pendingCompilation) {
-      return Promise.resolve();
+      return Promise.resolve(this.#hasErrors);
     }
 
     this.#compilationReadyPromise ??= new Promise((resolve) => {
@@ -23,8 +24,9 @@ export class SharedTSCompilationState {
     return this.#compilationReadyPromise;
   }
 
-  markAsReady(): void {
-    this.#resolveCompilationReady?.();
+  markAsReady(hasErrors: boolean): void {
+    this.#hasErrors = hasErrors;
+    this.#resolveCompilationReady?.(hasErrors);
     this.#compilationReadyPromise = undefined;
     this.#pendingCompilation = false;
   }
@@ -34,7 +36,7 @@ export class SharedTSCompilationState {
   }
 
   dispose(): void {
-    this.markAsReady();
+    this.markAsReady(true);
     globalSharedCompilationState = undefined;
   }
 }
diff --git a/packages/angular_devkit/build_angular/src/tools/esbuild/angular/compiler-plugin.ts b/packages/angular_devkit/build_angular/src/tools/esbuild/angular/compiler-plugin.ts
@@ -263,8 +263,7 @@ export function createCompilerPlugin(
         }
 
         if (compilation instanceof NoopCompilation) {
-          await sharedTSCompilationState.waitUntilReady;
-          hasCompilationErrors = false;
+          hasCompilationErrors = await sharedTSCompilationState.waitUntilReady;
 
           return result;
         }
@@ -318,7 +317,7 @@ export function createCompilerPlugin(
         // Reset the setup warnings so that they are only shown during the first build.
         setupWarnings = undefined;
 
-        sharedTSCompilationState.markAsReady();
+        sharedTSCompilationState.markAsReady(hasCompilationErrors);
 
         return result;
       });
@@ -409,7 +408,7 @@ export function createCompilerPlugin(
 
       build.onEnd((result) => {
         // Ensure other compilations are unblocked if the main compilation throws during start
-        sharedTSCompilationState?.markAsReady();
+        sharedTSCompilationState?.markAsReady(hasCompilationErrors);
 
         for (const { outputFiles, metafile } of additionalResults.values()) {
           // Add any additional output files to the main output files

Original file line number	Diff line number	Diff line change
`@@ -8,12 +8,13 @@`
`8`	`8`
`9`	`9`	`export class SharedTSCompilationState {`
`10`	`10`	`#pendingCompilation = true;`
`11`		`- #resolveCompilationReady: (() => void) \| undefined;`
`12`		`- #compilationReadyPromise: Promise<void> \| undefined;`
	`11`	`+ #resolveCompilationReady: ((value: boolean) => void) \| undefined;`
	`12`	`+ #compilationReadyPromise: Promise<boolean> \| undefined;`
	`13`	`+ #hasErrors = true;`
`13`	`14`
`14`		`- get waitUntilReady(): Promise<void> {`
	`15`	`+ get waitUntilReady(): Promise<boolean> {`
`15`	`16`	`if (!this.#pendingCompilation) {`
`16`		`- return Promise.resolve();`
	`17`	`+ return Promise.resolve(this.#hasErrors);`
`17`	`18`	`}`
`18`	`19`
`19`	`20`	`this.#compilationReadyPromise ??= new Promise((resolve) => {`
`@@ -23,8 +24,9 @@ export class SharedTSCompilationState {`
`23`	`24`	`return this.#compilationReadyPromise;`
`24`	`25`	`}`
`25`	`26`
`26`		`- markAsReady(): void {`
`27`		`- this.#resolveCompilationReady?.();`
	`27`	`+ markAsReady(hasErrors: boolean): void {`
	`28`	`+ this.#hasErrors = hasErrors;`
	`29`	`+ this.#resolveCompilationReady?.(hasErrors);`
`28`	`30`	`this.#compilationReadyPromise = undefined;`
`29`	`31`	`this.#pendingCompilation = false;`
`30`	`32`	`}`
`@@ -34,7 +36,7 @@ export class SharedTSCompilationState {`
`34`	`36`	`}`
`35`	`37`
`36`	`38`	`dispose(): void {`
`37`		`- this.markAsReady();`
	`39`	`+ this.markAsReady(true);`
`38`	`40`	`globalSharedCompilationState = undefined;`
`39`	`41`	`}`
`40`	`42`	`}`