Skip to content

feat(I18N Expander): do not add extra <ul> & <li> around ICU mess…#9283

Merged
vicb merged 1 commit intoangular:masterfrom
vicb:0616-i18n
Jun 17, 2016
Merged

feat(I18N Expander): do not add extra <ul> & <li> around ICU mess…#9283
vicb merged 1 commit intoangular:masterfrom
vicb:0616-i18n

Conversation

@vicb
Copy link
Copy Markdown
Contributor

@vicb vicb commented Jun 16, 2016

@vsavkin could you please review ?

The idea is that:

  1. We translate messages as a whole (not spliting every single cases)
  2. Expand ICU forms (this is not related to using i18n)

This PR removes the extra <ul> & <li> thanks to the new <ng-container>

@vicb vicb added feature Label used to distinguish feature request from other issues action: review The PR is still awaiting reviews from at least one requested reviewer area: i18n Issues related to localization and internationalization and removed cla: yes labels Jun 16, 2016
@vicb vicb mentioned this pull request Jun 16, 2016
21 tasks
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const

@vicb vicb merged commit 721f53f into angular:master Jun 17, 2016
@vicb
Copy link
Copy Markdown
Contributor Author

vicb commented Jun 17, 2016

got lgtm from @vsavkin

@vicb vicb deleted the 0616-i18n branch June 23, 2016 17:42
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer area: i18n Issues related to localization and internationalization cla: yes feature Label used to distinguish feature request from other issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants