Skip to content

fix(router): Do not intercept reload events with Navigation integration#66756

Merged
atscott merged 1 commit intoangular:mainfrom
atscott:nointerceptreload
Jan 26, 2026
Merged

fix(router): Do not intercept reload events with Navigation integration#66756
atscott merged 1 commit intoangular:mainfrom
atscott:nointerceptreload

Conversation

@atscott
Copy link
Contributor

@atscott atscott commented Jan 26, 2026

This commit prevents the Router from intercepting reload navigations in the navigate event listener. This would convert hard page reloads to SPA navigations.

fixes #66746

This commit prevents the Router from intercepting reload navigations
in the navigate event listener. This would convert hard page reloads
to SPA navigations.

fixes angular#66746
@atscott atscott added the target: patch This PR is targeted for the next patch release label Jan 26, 2026
@ngbot ngbot bot added this to the Backlog milestone Jan 26, 2026
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JeanMeche JeanMeche added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jan 26, 2026
@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Jan 26, 2026
@ngbot
Copy link

ngbot bot commented Jan 26, 2026

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "mergeability" is failing
    pending status "google-internal-tests" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@JeanMeche
Copy link
Member

JeanMeche commented Jan 26, 2026

This doesn't merge cleanly into 21.1, we'll need another PR to target patch.

@atscott atscott merged commit dbd50be into angular:main Jan 26, 2026
25 checks passed
@atscott
Copy link
Contributor Author

atscott commented Jan 26, 2026

This PR was merged into the repository. The changes were merged into the following branches:

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: router target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ng serve live-reload fails when withExperimentalPlatformNavigation is enabled

3 participants