Add support for spread syntax in templates #66213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
commented
Dec 21, 2025
| return this.sharedConstants.get(key)!; | ||
| } | ||
|
|
||
| getLiteralFactory(literal: o.LiteralArrayExpr | o.LiteralMapExpr): { |
Member
Author
There was a problem hiding this comment.
This method was unused so I deleted it and the related utilities.
9b830e5 to
016638e
Compare
JeanMeche
approved these changes
Jan 6, 2026
|
|
||
| do { | ||
| positionals.push(this.parsePipe()); | ||
| positionals.push(this.next.isOperator('...') ? this.parseSpreadElement() : this.parsePipe()); |
Member
There was a problem hiding this comment.
nit: should we create a custom method isSpearOperator ?
Updates the expression lexer to handle spread operators.
Updates the output AST to account for spread elements.
Updates the linker to account for spread assignments in object literals.
Updates the expression AST to have support for spread elements inside object literals.
Adds support for spread expressions inside of object literals. This can be handy when constructing maps for `class` bindings.
Adds the ability to generate spread elements in the linker.
Adds spread elements to the output AST which can be used in arrays and function calls.
Updates the expression AST to support spread elements that will be used for arrays and function calls.
Expands the template syntax to support spread elements inside arrays. This can be handy for some bindings.
016638e to
4e50304
Compare
Updates the template syntax to support rest arguments in function calls. This can be handy for functions with a variable number of arguments.
4e50304 to
355588a
Compare
Contributor
|
This PR was merged into the repository. The changes were merged into the following branches:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for spread/rest syntax in the following places in the template syntax:
{a: 1, ...foo}.[1, ...foo].fn(1, ...foo).For arrays and object literals the spread arguments integrate into the existing pure function infrastructure in order to avoid re-creating the object on each change detection.
Fixes #11850.
Fixes #61800.
Note: I took a couple of commits from #66206 and #66190 to avoid conflicts.