Skip to content

fix(compiler-cli): missingStructuralDirective diagnostic produces fal… #64579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JeanMeche wants to merge 1 commit into from
Closed

fix(compiler-cli): missingStructuralDirective diagnostic produces fal… #64579

JeanMeche wants to merge 1 commit into from

Conversation

@JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Oct 22, 2025

…se negatives

Fixes a bug in the missingStructuralDirective diagnostic where structural directives with missing imports were not reported when the element using the structural directive contained other directives

Fixes #64467

@pullapprove pullapprove bot requested a review from kirjs October 22, 2025 12:50
@angular-robot angular-robot bot added the area: compiler Issues related to `ngc`, Angular's template compiler label Oct 22, 2025
@JeanMeche JeanMeche mentioned this pull request Oct 22, 2025
Closed
14 tasks
@ngbot ngbot bot added this to the Backlog milestone Oct 22, 2025
@JeanMeche
Copy link
Member Author

JeanMeche commented Oct 22, 2025

@mattlewis92 Could you please sign the CLA, I've added you as co-author on the commit.

@mattlewis92
Copy link
Contributor

mattlewis92 commented Oct 22, 2025

@mattlewis92 Could you please sign the CLA, I've added you as co-author on the commit.

It looks like I committed under the wrong email, can you change the commit author to npm@mattlewis.me instead and that should make it pass?

@JeanMeche
fix(compiler-cli): missingStructuralDirective diagnostic produces fal…
6f8a171 
…se negatives

Fixes a bug in the missingStructuralDirective diagnostic where structural directives with missing imports were not reported when the element using the structural directive contained other directives

Fixes angular#64467

co-authored-by: Matt Lewis <npm@mattlewis.me>
@JeanMeche
Copy link
Member Author

JeanMeche commented Oct 22, 2025

Thanks for the quick feedback, we're good now !

@JeanMeche JeanMeche added the target: major This PR is targeted for the next major release label Oct 22, 2025
@JeanMeche
Copy link
Member Author

JeanMeche commented Oct 22, 2025

G3 has been cleaned up.

Since this is somehow breaking (it was inside G3), we'll target the next major for it !

thePunderWoman
thePunderWoman approved these changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

reviewed-for: fw-compiler, public-api

@thePunderWoman thePunderWoman removed the request for review from kirjs October 22, 2025 16:10
@JeanMeche JeanMeche added the action: merge The PR is ready for merge by the caretaker label Oct 22, 2025
@thePunderWoman
Copy link
Contributor

thePunderWoman commented Oct 22, 2025

This PR was merged into the repository. The changes were merged into the following branches:

@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Nov 22, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler target: major This PR is targeted for the next major release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

missingStructuralDirective diagnostic ignores elements with other directives

3 participants

@JeanMeche @mattlewis92 @thePunderWoman