Skip to content

fix(common): properly type ngComponentOutlet#64561

Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto:component-outlet-type
Closed

fix(common): properly type ngComponentOutlet#64561
crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto:component-outlet-type

Conversation

@crisbeto
Copy link
Copy Markdown
Member

Resolves an older TODO about properly typing the ngComponentOutlet input.

Resolves an older TODO about properly typing the `ngComponentOutlet` input.
@crisbeto crisbeto added the target: minor This PR is targeted for the next minor release label Oct 21, 2025
@angular-robot angular-robot bot added the area: common Issues related to APIs in the @angular/common package label Oct 21, 2025
@ngbot ngbot bot added this to the Backlog milestone Oct 21, 2025
@crisbeto crisbeto requested a review from devversion October 21, 2025 11:59
@crisbeto crisbeto added the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 21, 2025
@crisbeto crisbeto marked this pull request as ready for review October 21, 2025 11:59
@crisbeto
Copy link
Copy Markdown
Member Author

Passing TGP

Copy link
Copy Markdown
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Copy Markdown
Member

@JeanMeche JeanMeche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@crisbeto crisbeto modified the milestones: Backlog, v21 Candidate Oct 21, 2025
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 21, 2025
@crisbeto
Copy link
Copy Markdown
Member Author

Caretaker note: I can't remove the remaining reviews because of a Github bug.

Copy link
Copy Markdown
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this could be potentially breaking, but I see that this is also a "fix".

Reviewed-for: public-api

@thePunderWoman
Copy link
Copy Markdown
Contributor

This PR was merged into the repository. The changes were merged into the following branches:

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants