fix(core): fixes empty animations when recalculating styles #63007
Conversation
7e6ca5c to
e53d841
Compare
Any time something causes styles to recalculate, `element.getAnimations()` will be empty. This updates `animate.enter` and `animate.leave` to rely on `getComputedStyles` to determine the longest animation instead. fixes: angular#63006
e53d841 to
cc6e168
Compare
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken |
|
This PR was merged into the repository by commit ebd622b. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Any time something causes styles to recalculate,
element.getAnimations()will be empty. This updatesanimate.enterandanimate.leaveto rely ongetComputedStylesas a fallback to determine the longest animation.This should also improve performance as this reduces the calls to get the longest animation only when the event.target is the element in question. It'll ignore bubbled up animation events now.
fixes: #63006