Skip to content

fix(core): fixes timing issues with enter animations #62925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thePunderWoman wants to merge 1 commit into from
Closed

fix(core): fixes timing issues with enter animations #62925

thePunderWoman wants to merge 1 commit into from

Conversation

@thePunderWoman
Copy link
Contributor

@thePunderWoman thePunderWoman commented Jul 31, 2025

In some patterns, element.getAnimations() will be an empty array despite the animation class being present during animation start and the style sheet showing a keyframe animation. Moving the longest animation check to the end resolves this problem.

fixes: #62923

Does this PR introduce a breaking change?

  • Yes
  • No

@thePunderWoman
fix(core): fixes timing issues with enter animations
d6554d0 
In some patterns, `element.getAnimations()` will be an empty array despite the animation class being present during animation start and the style sheet showing a keyframe animation.
Moving the longest animation check to the end resolves this problem.

fixes: angular#62923
@thePunderWoman thePunderWoman added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: minor This PR is targeted for the next minor release labels Jul 31, 2025
@ngbot ngbot bot modified the milestone: Backlog Jul 31, 2025
@thePunderWoman thePunderWoman removed the request for review from crisbeto July 31, 2025 18:33
@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 31, 2025
@ngbot
Copy link

ngbot bot commented Jul 31, 2025

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "google-internal-tests" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@thePunderWoman thePunderWoman added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Aug 1, 2025
@thePunderWoman
Copy link
Contributor Author

thePunderWoman commented Aug 1, 2025

Caretaker note: the failing g3 tests are flakes. This is safe to merge.

@thePunderWoman
Copy link
Contributor Author

thePunderWoman commented Aug 1, 2025

This PR was merged into the repository by commit 455b147.

The changes were merged into the following branches: main

@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 1, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 1, 2025
@thePunderWoman thePunderWoman deleted the animation-fix branch September 12, 2025 16:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alxhub alxhub alxhub approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Animation enter fails to remove after animation completes

2 participants

@thePunderWoman @alxhub