-
Notifications
You must be signed in to change notification settings - Fork 27k
fix(compiler-cli): display proper function in NG8117 message #62842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This seems to indicate a larger problem at play, where the original source seems to have been |
...er-cli/src/ngtsc/typecheck/extended/checks/uninvoked_function_in_text_interpolation/index.ts
Outdated
Show resolved
Hide resolved
The diagnostic was displaying `'Function in text interpolation should be invoked: ect Object]()` instead of `'Function in text interpolation should be invoked: firstName()'.
a713ebd to
c60f3bb
Compare
|
@JoostK @JeanMeche I removed the |
thePunderWoman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
|
This PR was merged into the repository by commit c491707. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The diagnostic was displaying
'Function in text interpolation should be invoked: ect Object]()What is the new behavior?
The diagnostic displays `'Function in text interpolation should be invoked: firstName()'.
Does this PR introduce a breaking change?
Other information