-
Notifications
You must be signed in to change notification settings - Fork 27k
refactor(animations): deprecate the animations package #62795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(animations): deprecate the animations package #62795
Conversation
b3a4835 to
dbf0128
Compare
devversion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reviewed-for: public-api
mmalerba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed-for: public-api
dbf0128 to
eba87ea
Compare
This deprecates the animations package in favor of using `animate.enter` and `animate.leave` with intent to remove the full package in v22.2. DEPRECATED: @angular/animations
eba87ea to
dc9fa37
Compare
AndrewKushnir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-for: public-api
|
This PR was merged into the repository by commit 9766116. The changes were merged into the following branches: main |
What does this refer to? |
|
I saw that EDIT: add some context - updated to 20.2 today. |
|
|
Huh that's weird. I'll do more digging. Thanks for the reply. |
|
Make sure to have a look at the dedicated doc page ! https://angular.dev/guide/animations/enter-and-leave |
|
@princemaple if you do continue to have programs, definitely open an issue with a repro. That goes a long way. |
|
FYI |
|
I think there indeed is a bug somewhere. Please see #63307 |
|
are angular removing the animation package @thePunderWoman completely |
|
if yes then what we going to use then a core css or new package will come if new package come that will be great |
|
@mdex-geek Yes we will in v23. We've already created replacement animation APIs that are available. See https://angular.dev/guide/animations/enter-and-leave, mentioned earlier. |
|
@mdex-geek Use modern in most cases. For entre/leave animations we also provide custom template instructions : https://angular.dev/guide/animations/enter-and-leave |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This deprecates the animations package in favor of using
animate.enterandanimate.leavewith intent to remove the full package in v22.2.DEPRECATED: @angular/animations