-
Notifications
You must be signed in to change notification settings - Fork 27k
feat(service-worker): Adds support for updateViaCache in provideServi… #62721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ceWorker Enables configuration of the updateViaCache setting for service worker registration, allowing greater control over caching behavior during updates. Extends tests to cover new option and ensures correct propagation in registration logic.
…deServiceWorker Enables configuration of the updateViaCache setting for service worker registration, allowing greater control over caching behavior during updates. Extends tests to cover new option and ensures correct propagation in registration logic.
|
@thePunderWoman You can run it again. I already corrected some unit tests that I had not been able to run locally. I just learned how to run them due to environmental differences. |
|
@thePunderWoman You can run it again, it seems there is flaky test in firefox, locally they worked for me |
thePunderWoman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
reviewed-for: fw-general, public-api
JeanMeche
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed-for: public-api
|
This PR was merged into the repository by commit 4ac6171. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |


This commit adds support for the
updateViaCacheoption when configuring Angular Service Workers.The change includes:
updateViaCachetoSwRegistrationOptionsinterfaceupdateViaCacheoptionMotivation/Use Cases
The
updateViaCacheoption is particularly useful for:Proposed Solution
updateViaCacheproperty to theSwRegistrationOptionsabstract classnavigator.serviceWorker.register()APIExamples of New Usage
Basic configuration with provideServiceWorker