fix(http): Add missing timeout and transferCache options to HttpClient
#62586
Conversation
The `timeout` option is implemented in the different HTTP backends, but the option is not actually passed to the backends. `transferCache` is also missing in one signature. This commit adds both options to `HttpClient`. Fixes angular#62581
3644234 to
679822e
Compare
|
By looking at the PR I don't see any changes around |
|
I pointed out where it's added in a review. Also, I had also mentioned transferCache in general in my PR comment. Iit's absent for PUT, but is present for POST. It does seem inconsistent to me, but I might be overlooking something. Was wondering if I should update the commit to add it everywhere. |
|
The reasoning behind that is that |
thePunderWoman
left a comment
There was a problem hiding this comment.
Whoa whoa whoa...timeout!
Sorry, couldn't resist. LGTM!
reviewed-for: fw-general, public-api
|
This PR was merged into the repository by commit 1408baf. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The
timeoutoption is implemented in the different HTTP backends, but the option is not actually passed to the backends.transferCacheis also missing in one signature. This commit adds both options toHttpClientPR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Issue Number: N/A
Other information
I noticed while doing this that the
transferCacheoption is not always passed. I am not sure why, but in DELETE and PUT requests it's absent, while for GET and POST requests, it is there.While I understand why it's there for GET, I question why it's absent in PUT if POST has the option. I believe it should be added everywhere for consistency. I can change this PR to do that if needed.