Skip to content

fix(core): Fixes template outlet hydration #61989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thePunderWoman wants to merge 1 commit into from
Closed

fix(core): Fixes template outlet hydration #61989

thePunderWoman wants to merge 1 commit into from

Conversation

@thePunderWoman
Copy link
Contributor

@thePunderWoman thePunderWoman commented Jun 10, 2025

Projected nodes were missing ssrId information and were skipping annotating template information, which caused templates to be destroyed and recreated rather than hydrated.

fixes: #50543

Does this PR introduce a breaking change?

  • Yes
  • No

@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Jun 10, 2025
@ngbot ngbot bot added this to the Backlog milestone Jun 10, 2025
@thePunderWoman thePunderWoman added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jun 10, 2025
@thePunderWoman thePunderWoman marked this pull request as ready for review June 10, 2025 16:34
AndrewKushnir
AndrewKushnir reviewed Jun 10, 2025
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jessicajaniuk this is great, very nice fix 👍 I've left a couple minor comments.

@thePunderWoman
fix(core): Fixes template outlet hydration
fe58cb1 
Projected nodes were missing ssrId information and were skipping annotating template information, which caused templates to be destroyed and recreated rather than hydrated.

fixes: angular#50543
@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer action: merge The PR is ready for merge by the caretaker labels Jun 11, 2025
@ngbot
Copy link

ngbot bot commented Jun 11, 2025

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "mergeability" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@thePunderWoman thePunderWoman added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jun 11, 2025
@pkozlowski-opensource
Copy link
Member

pkozlowski-opensource commented Jun 12, 2025

This PR was merged into the repository by commit 8424b3b.

The changes were merged into the following branches: main

@thePunderWoman thePunderWoman deleted the simple-hydration-fix branch July 1, 2025 11:41
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Aug 1, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

ng-template gets rendered twice during hydration (when anchor comment node is not projected)

3 participants

@thePunderWoman @pkozlowski-opensource @AndrewKushnir