Skip to content

Conversation

@arturovt
Copy link
Contributor

@arturovt arturovt commented Jun 3, 2025

In this commit, support for pushsubscriptionchange events has been added to the service worker Driver.

When the push subscription changes, the Driver now captures the event and broadcasts a PUSH_SUBSCRIPTION_CHANGE message to clients. This ensures the application is aware of push events and can react accordingly.

Unfortunately, it's not possible to perform any end-to-end testing of this feature.

The push subscription change event exists in both Blink and Gecko. It is also supported in the latest version of Chrome, which means we can give users the ability to react to this event in order to gather feedback on whether other components might need updates.

In this commit, support for `pushsubscriptionchange` events has been added to the service worker Driver.

When the push subscription changes, the Driver now captures the event and broadcasts a `PUSH_SUBSCRIPTION_CHANGE` message to clients. This ensures the application is aware of push events and can react accordingly.

Unfortunately, it's not possible to perform any end-to-end testing of this feature.

The push subscription change event exists in both Blink and Gecko. It is also supported in the latest version of Chrome, which means we can give users the ability to react to this event in order to gather feedback on whether other components might need updates.
@pullapprove pullapprove bot requested a review from mmalerba June 3, 2025 22:02
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: service-worker Issues related to the @angular/service-worker package labels Jun 3, 2025
@ngbot ngbot bot added this to the Backlog milestone Jun 3, 2025
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

reviewed-for: fw-general, public-api

@pullapprove pullapprove bot requested review from kirjs and thePunderWoman June 4, 2025 16:43
@thePunderWoman thePunderWoman removed their request for review June 4, 2025 16:44
@thePunderWoman thePunderWoman added the target: patch This PR is targeted for the next patch release label Jun 4, 2025
@pullapprove pullapprove bot requested a review from crisbeto June 4, 2025 16:44
@thePunderWoman thePunderWoman added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jun 4, 2025
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Jun 4, 2025
@ngbot
Copy link

ngbot bot commented Jun 4, 2025

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "mergeability" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels Jun 4, 2025
@ngbot
Copy link

ngbot bot commented Jun 4, 2025

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "mergeability" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@kirjs
Copy link
Contributor

kirjs commented Jun 4, 2025

This PR was merged into the repository by commit 6e1df54.

The changes were merged into the following branches: main

@kirjs kirjs closed this in 6e1df54 Jun 4, 2025
@arturovt arturovt deleted the feat/service-worker-subscription-change branch June 4, 2025 21:13
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: service-worker Issues related to the @angular/service-worker package detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants