Skip to content

feat(http): add keepalive support for fetch requests in httpResource #61833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SkyZeroZx wants to merge 1 commit into from
Closed

feat(http): add keepalive support for fetch requests in httpResource #61833

SkyZeroZx wants to merge 1 commit into from

Conversation

@SkyZeroZx
Copy link
Contributor

@SkyZeroZx SkyZeroZx commented Jun 2, 2025 •
edited
Loading

This commit adds support for the Fetch API's keepalive option when using httpResource with the withFetch provider.

The keepalive option is particularly useful for:

Beacon API-like functionality (logging analytics on page unload)
Better control over connection management in long-lived applications

Example new usage :

httpResource(() => ({
  url: '/api/log',
  method: 'POST',
  keepalive: true,
}));

@pullapprove pullapprove bot requested a review from AndrewKushnir June 2, 2025 19:11
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: common/http Issues related to HTTP and HTTP Client labels Jun 2, 2025
@ngbot ngbot bot added this to the Backlog milestone Jun 2, 2025
@SkyZeroZx SkyZeroZx mentioned this pull request Jun 2, 2025
Closed
@AndrewKushnir AndrewKushnir requested review from alxhub and removed request for AndrewKushnir June 4, 2025 01:18
cyber-hari
cyber-hari approved these changes Jun 8, 2025
View reviewed changes
Copy link

@cyber-hari cyber-hari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SkyZeroZx
Copy link
Contributor Author

SkyZeroZx commented Jun 9, 2025

@alxhub Is any additional validation needed to be able to merge it?

thePunderWoman
thePunderWoman approved these changes Jun 24, 2025
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

reviewed-for: fw-general, public-api

@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Jun 24, 2025
@JeanMeche JeanMeche removed the action: merge The PR is ready for merge by the caretaker label Jun 24, 2025
@SkyZeroZx @thePunderWoman
feat(http): add keepalive support for fetch requests in httpResource
30290b1 
This commit adds support for the Fetch API's keepalive option when using httpResource with the withFetch provider
@thePunderWoman thePunderWoman force-pushed the add-keepalive-httpresource branch from 68629eb to 30290b1 Compare June 24, 2025 12:53
kirjs
kirjs approved these changes Jun 24, 2025
View reviewed changes
Copy link
Contributor

@kirjs kirjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@thePunderWoman thePunderWoman added the action: merge The PR is ready for merge by the caretaker label Jun 24, 2025
@thePunderWoman
Copy link
Contributor

thePunderWoman commented Jun 25, 2025

This PR was merged into the repository by commit 73269cf.

The changes were merged into the following branches: main

@SkyZeroZx SkyZeroZx deleted the add-keepalive-httpresource branch June 26, 2025 01:55
@SkyZeroZx SkyZeroZx mentioned this pull request Jun 26, 2025
Closed
11 tasks
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jul 27, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

@thePunderWoman thePunderWoman thePunderWoman approved these changes

@kirjs kirjs kirjs approved these changes

+2 more reviewers

@syamoka syamoka syamoka approved these changes

@cyber-hari cyber-hari cyber-hari approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: common/http Issues related to HTTP and HTTP Client detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

6 participants

@SkyZeroZx @thePunderWoman @JeanMeche @kirjs @syamoka @cyber-hari