Skip to content

Conversation

@arturovt
Copy link
Contributor

@arturovt arturovt commented May 16, 2025

In this commit, support for notificationclose events has been added to the service worker Driver.

When a notification is closed (either by user dismissal or programmatically), the Driver now captures the event, extracts the relevant notification options, and broadcasts a NOTIFICATION_CLOSE message to clients. This ensures the application is aware of notification lifecycle events and can react accordingly.

@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: service-worker Issues related to the @angular/service-worker package labels May 16, 2025
@ngbot ngbot bot added this to the Backlog milestone May 16, 2025
@arturovt arturovt force-pushed the feat/service-worker-notificationClose branch 2 times, most recently from 76c0172 to 4224ee1 Compare May 16, 2025 22:09
In this commit, support for `notificationclose` events has been added to the service worker Driver.

When a notification is closed (either by user dismissal or programmatically), the Driver now captures the event, extracts the relevant notification options, and broadcasts a `NOTIFICATION_CLOSE` message to clients. This ensures the application is aware of notification lifecycle events and can react accordingly.
@arturovt arturovt force-pushed the feat/service-worker-notificationClose branch from 4224ee1 to 03427c6 Compare May 17, 2025 15:31
@arturovt arturovt marked this pull request as ready for review May 20, 2025 21:25
@pullapprove pullapprove bot requested a review from alxhub May 20, 2025 21:25
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

reviewed-for: fw-general, public-api

@thePunderWoman thePunderWoman removed the request for review from alxhub June 3, 2025 11:14
@pullapprove pullapprove bot requested review from AndrewKushnir and atscott June 3, 2025 11:14
@thePunderWoman thePunderWoman added the action: merge The PR is ready for merge by the caretaker label Jun 3, 2025
@pullapprove pullapprove bot requested a review from alxhub June 3, 2025 11:15
@thePunderWoman thePunderWoman added the target: patch This PR is targeted for the next patch release label Jun 3, 2025
Copy link
Contributor

@kirjs kirjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@kirjs kirjs closed this Jun 3, 2025
@kirjs kirjs reopened this Jun 3, 2025
@kirjs kirjs added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jun 3, 2025
@kirjs
Copy link
Contributor

kirjs commented Jun 3, 2025

This PR was merged into the repository by commit c67dbda.

The changes were merged into the following branches: main

@kirjs kirjs closed this in c67dbda Jun 3, 2025
@arturovt arturovt deleted the feat/service-worker-notificationClose branch June 3, 2025 20:37
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: service-worker Issues related to the @angular/service-worker package detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants