Skip to content

fix(core): fakeAsync should not depend on module import order #61375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
atscott wants to merge 1 commit into from
Closed

fix(core): fakeAsync should not depend on module import order #61375

atscott wants to merge 1 commit into from

Conversation

@atscott
Copy link
Contributor

@atscott atscott commented May 15, 2025 •
edited
Loading

fakeAsync does not work if the zone-testing polyfill is included after
@angular/core/testing is loaded. This allows fakeAsync to work
even if the zone-testing is included later.

@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label May 15, 2025
@ngbot ngbot bot added this to the Backlog milestone May 15, 2025
@atscott atscott added the target: patch This PR is targeted for the next patch release label May 15, 2025
@atscott atscott changed the title Fake async fixes fix(core): fakeAsync should not depend on module import order May 16, 2025
@atscott atscott added the action: merge The PR is ready for merge by the caretaker label May 22, 2025
@ngbot
Copy link

ngbot bot commented May 22, 2025

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "google-internal-tests" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@atscott atscott added target: rc This PR is targeted for the next release-candidate and removed target: patch This PR is targeted for the next patch release labels May 22, 2025
@atscott
fix(core): fakeAsync should not depend on module import order
1c27acf 
`fakeAsync` does not work if the zone-testing polyfill is included after
@angular/core/testing is loaded. This allows fakeAsync to work
even if the zone-testing is included later.
@atscott atscott added target: minor This PR is targeted for the next minor release and removed target: rc This PR is targeted for the next release-candidate labels May 22, 2025
@atscott
Copy link
Contributor Author

atscott commented May 23, 2025

This PR was merged into the repository by commit 4356e85.

The changes were merged into the following branches: main

@atscott atscott closed this in 4356e85 May 23, 2025
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jun 23, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

2 participants

@atscott @AndrewKushnir