fix(core): missing useExisting providers throwing for optional calls #61137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
commented
May 6, 2025
packages/core/src/di/r3_injector.ts
Outdated
Member
Author
There was a problem hiding this comment.
This is the call site that was missing the flags.
Fixes that the runtime was throwing a DI error when attempting to inject a missing `useExisting` provider, despite the call being optional. The problem was that when the provider has `useExisting`, we do a second `inject` call under the hood which didn't include the inject flags from the original call. Fixes angular#61121.
bdc06e5 to
970538e
Compare
Member
Author
Contributor
|
This PR was merged into the repository by commit 583b9a7. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that the runtime was throwing a DI error when attempting to inject a missing
useExistingprovider, despite the call being optional.The problem was that when the provider has
useExisting, we do a secondinjectcall under the hood which didn't include the inject flags from the original call.Fixes #61121.