Closed
Conversation
ef2b989 to
f5bb124
Compare
JeanMeche
reviewed
Apr 1, 2025
josephperrott
requested changes
Apr 2, 2025
efd6d08 to
7825c04
Compare
JeanMeche
reviewed
Apr 4, 2025
devversion
reviewed
Apr 4, 2025
7825c04 to
2a9d55c
Compare
2a9d55c to
0b9fe8a
Compare
alxhub
approved these changes
Apr 18, 2025
388387f to
ad797ad
Compare
ad797ad to
ca83bd2
Compare
Member
Author
|
After the approvals were done I changed the error message from: 'Resource failed to load' to `Resource is currently in the error state'. I also removed untracking of the stream https://github.com/angular/angular/pull/60610/files#diff-16f6b7cc4c4e69b511c8312d38c6cf71c412e6f1d6ac9092054c0f349215cdedR418, because there were some cases in g3, where |
ca83bd2 to
f788f52
Compare
f788f52 to
886c7ce
Compare
pkozlowski-opensource
approved these changes
Apr 25, 2025
Member
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
devversion
approved these changes
Apr 29, 2025
Member
devversion
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
ff4cfdc to
3161918
Compare
It was set to es2022 for build tsconfig in https://github.com/angular/angular/pull/60066/files#diff-7ec658aedc62a693cc513accc8f360938d90bcbdb09aa79c1401e56fe84f5fd3, but was missed for the main one.
Now only mutable resources can be reloaded BREAKING CHANGE: * `Resource.reload` has been moved to `WritableResource.reload`.
`Resource.error` used to return `unknown`. Now it's `Error | undefined`. For non-`Error` types they are encapsulated with the `Error` type. BREAKING CHANGE: * `Resource.error` now has a type of `Signal<Error | undefined>` instead of `Signal<unknown>`
…g undefined When there is an underlying error state it would not be possible to swallow the error with: `computed(() => res.value()?.inner);` BREAKING CHANGE: * `Resource.value()` now throws an error when it's in an error state. Previously it returned `undefined`.
When the resource is loading after reloading from the error state reading `Resource.value()` would return the default value instead of throwing an error. This change prevents `Resource.hasValue()` from throwing an error in such a case. BREAKING CHANGE: * `Resource.value()` now returns a default value when in a loading state after reloading the error state
3795382 to
5e62b07
Compare
Contributor
|
Since I was one of the people mentioning error typing during the RFC, I'm wondering about two things:
|
Member
|
Changes landed as part of #61441 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.