feat(core): emit template function for template related profiler hooks#60174
Closed
AleksanderBodurri wants to merge 1 commit intoangular:mainfrom
Closed
Conversation
99ec09f to
550ebc5
Compare
Previously, the profiler would only emit the specific template event and context when a template is created/updated, but not the template function related to the event. This commit emits this function by using the third argument of the profiler function, which previously was only used for lifecycle hooks and output listeners. This commit also renames this arg to eventFn to express that it varies depending on the event type emitting from the profiler. Note: this change is fully backwards compatible, since previously these template events did not use the third arg of the profiler function.
550ebc5 to
640f5bf
Compare
pkozlowski-opensource
approved these changes
Mar 3, 2025
Member
|
Thnx @AleksanderBodurri ! |
Contributor
|
This PR was merged into the repository by commit d260ca3. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the profiler would only emit the specific template event and context when a template is created/updated, but not the template function related to the event.
This commit emits this function by using the third argument of the profiler function, which previously was only used for lifecycle hooks and output listeners. This commit also renames this arg to
eventFnto express that it varies depending on the event type emitting from the profiler.Note: this change is fully backwards compatible, since previously these template events did not use the third arg of the profiler function.