fix(core): Flush animations when no component has been checked by CD#58089
Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): Flush animations when no component has been checked by CD#58089JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche wants to merge 1 commit intoangular:mainfrom
Conversation
4564414 to
ebdda3b
Compare
ebdda3b to
33c4811
Compare
33c4811 to
1b677c5
Compare
1b677c5 to
b6986ee
Compare
b6986ee to
1b52af2
Compare
1b52af2 to
2741a92
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
2741a92 to
965054a
Compare
24ef696 to
3d34822
Compare
3d34822 to
47d7760
Compare
47d7760 to
1b82a35
Compare
5a26e95 to
1f17456
Compare
When Angular runs application synchronization automatically, animations are now guaranteed to be flushed, regardless of whether change detection was run on any components attached to `ApplicationRef`. This most frequently affects animations related to component removal where the DOM element for the component would previously not be removed due to animations not being flushed BREAKING CHANGE: Animations are guaranteed to be flushed when Angular runs automatic change detection or manual calls to `ApplicationRef.tick`. Prior to this change, animations would not be flushed in some situations if change detection did not run on any views attached to the application. This change can affect tests which may rely on the old behavior, often by making assertions on DOM elements that should have been removed but weren't because DOM removal is delayed until animations are flushed. fixes angular#58075
1f17456 to
07c2ae4
Compare
Contributor
|
Green TGP (with local changes to fix tests). |
atscott
approved these changes
Apr 7, 2025
atscott
approved these changes
Apr 8, 2025
Contributor
|
This PR was merged into the repository by commit 0b69b61. The changes were merged into the following branches: main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #58075