refactor(core): introduce debugName optional arg to ReactiveNode #57710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7a28bf4 to
7c91874
Compare
dgp1130
approved these changes
Sep 12, 2024
Member
Author
|
Awaiting g3sync run @alxhub |
alxhub
approved these changes
Sep 24, 2024
Member
alxhub
left a comment
There was a problem hiding this comment.
LGTM - just needs a change to the commit message to use refactor(core) instead of feat(core), because this is not a user visible feature.
Member
|
Caretaker: TGP not required (type-only change, can't affect production) |
7c91874 to
6fee943
Compare
This commit contains the changes to core/primitives that used to be in angular#57073.
6fee943 to
f6813b3
Compare
AndrewKushnir
approved these changes
Oct 7, 2024
AndrewKushnir
approved these changes
Oct 7, 2024
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
Contributor
|
TESTED=No TGP required, see #57710 (comment). |
Contributor
|
This PR was merged into the repository by commit 837af44. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains the changes to core/primitives that used to be in #57073 but were moved for g3sync