Skip to content

docs: add new key/value option syntax in CLI#57699

Closed
hybrist wants to merge 1 commit intoangular:mainfrom
hybrist:define-flag
Closed

docs: add new key/value option syntax in CLI#57699
hybrist wants to merge 1 commit intoangular:mainfrom
hybrist:define-flag

Conversation

@hybrist
Copy link
Contributor

@hybrist hybrist commented Sep 6, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Documents the new supported syntax for CLI options.

This PR likely shouldn't land until the new CLI feature has landed (and/or is released): angular/angular-cli#28362

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@angular-robot angular-robot bot added the area: docs Related to the documentation label Sep 6, 2024
@ngbot ngbot bot added this to the Backlog milestone Sep 6, 2024
@hybrist hybrist marked this pull request as ready for review September 6, 2024 18:26
@pullapprove pullapprove bot requested a review from josephperrott September 6, 2024 18:26
@github-actions
Copy link

github-actions bot commented Sep 6, 2024 •
edited
Loading

Deployed adev-preview for bf020af to: https://ng-dev-previews-fw--pr-angular-angular-57699-adev-prev-1p9ipm97.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@hybrist
Copy link
Contributor Author

hybrist commented Sep 6, 2024

Checked rendered content on https://ng-dev-previews-fw--pr-angular-angular-57699-adev-prev-1p9ipm97.web.app/tools/cli and it looks like this worked.

josephperrott
josephperrott approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Sep 9, 2024
alan-agius4
alan-agius4 approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Sep 9, 2024
@thePunderWoman
Copy link
Contributor

thePunderWoman commented Sep 9, 2024

This PR was merged into the repository by commit 9c5b466.

The changes were merged into the following branches: main

@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Oct 10, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@josephperrott josephperrott josephperrott approved these changes

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation target: major This PR is targeted for the next major release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@hybrist @thePunderWoman @josephperrott @alan-agius4