language-service: added test cases which currently don't pass because of #56476 #56506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eneajaho
commented
Jul 8, 2024
Comment on lines
+782
to
+787
| const nestedSymbol = templateTypeChecker.getSymbolOfNode(nodes[0].inputs[1].value, cmp)!; | ||
| assertExpressionSymbol(nestedSymbol); | ||
| expect(program.getTypeChecker().symbolToString(nestedSymbol.tsSymbol!)).toEqual( | ||
| 'helloWorld1', | ||
| ); | ||
| expect(program.getTypeChecker().typeToString(nestedSymbol.tsType)).toEqual('string'); |
Contributor
Author
There was a problem hiding this comment.
This passes now because I added:
else if (ts.isCallExpression(node)) {
tsSymbol = this.getTypeChecker().getSymbolAtLocation(node.expression);
}
Contributor
Author
|
Closing as couldn't find a way to fix it 😅 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just running new tests
Related #56476