fix(migrations): handle empty ngSwitchCase#56103
Closed
naaajii wants to merge 1 commit intoangular:17.3.xfrom
Closed
fix(migrations): handle empty ngSwitchCase#56103naaajii wants to merge 1 commit intoangular:17.3.xfrom
naaajii wants to merge 1 commit intoangular:17.3.xfrom
Conversation
empty ngSwitchCase generate `case () {` which isn't valid syntax therefore adding quotes will help prevent us migrate empty case if no condition was provided
fix angular#56030
Member
|
Hi, |
Contributor
Author
|
thank you for the headsup! |
14 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
empty ngSwitchCase generate
case () {which isn't valid syntax therefore adding quotes will help prevent us migrate empty case if no condition was providedfix #56030
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #56030
control flow cases being generated with no fallback value in them
What is the new behavior?
control flow cases contain single quotes if ngSwitchCase didnt had any value in it
Does this PR introduce a breaking change?
Other information