Skip to content

refactor(animations): remove deprecated matchesElement from AnimationDriver#55479

Closed
alan-agius4 wants to merge 1 commit intoangular:mainfrom
alan-agius4:animations-match-element-remove
Closed

refactor(animations): remove deprecated matchesElement from AnimationDriver#55479
alan-agius4 wants to merge 1 commit intoangular:mainfrom
alan-agius4:animations-match-element-remove

Conversation

@alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Apr 23, 2024

BREAKING CHANGE: Deprecated matchesElement method has been removed from AnimationDriver as it is unused.

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Apr 23, 2024
@angular-robot angular-robot bot added the detected: breaking change PR contains a commit with a breaking change label Apr 23, 2024
…ionDriver`

BREAKING CHANGE: Deprecated `matchesElement` method has been removed from `AnimationDriver` as it is unused.
@alan-agius4 alan-agius4 force-pushed the animations-match-element-remove branch from d548b0b to e75a810 Compare April 23, 2024 11:43
@ngbot ngbot bot removed this from the v18 feature freeze candidates milestone Apr 23, 2024
@alan-agius4 alan-agius4 marked this pull request as ready for review April 23, 2024 11:45
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: fw-animations, fw-testing, public-api

Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 23, 2024
Copy link
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@alxhub
Copy link
Member

alxhub commented Apr 23, 2024

This PR was merged into the repository by commit bcce85a.

@alxhub alxhub closed this in bcce85a Apr 23, 2024
@alan-agius4 alan-agius4 deleted the animations-match-element-remove branch April 23, 2024 20:07
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker detected: breaking change PR contains a commit with a breaking change target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants