Skip to content

refactor(migrations): remove v17 migrations#55391

Closed
alan-agius4 wants to merge 1 commit intoangular:mainfrom
alan-agius4:migration-clean
Closed

refactor(migrations): remove v17 migrations#55391
alan-agius4 wants to merge 1 commit intoangular:mainfrom
alan-agius4:migration-clean

Conversation

@alan-agius4
Copy link
Contributor

This commit removes of migrations introduced in version 17, along with the relocation of a migration from 17.3 to version 18. This ensures that this is ran for users who may have updated from one minor to another without executing ng update

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release area: migrations Issues related to `ng update`/`ng generate` migrations labels Apr 18, 2024
@ngbot ngbot bot added this to the Backlog milestone Apr 18, 2024
@pullapprove pullapprove bot requested a review from crisbeto April 18, 2024 08:50
This commit removes of migrations introduced in version 17, along with the relocation of a migration from 17.3 to version 18. This ensures that this is ran for users who may have updated from one minor to another without executing `ng update`
@alan-agius4 alan-agius4 reopened this Apr 18, 2024
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 18, 2024
@alxhub
Copy link
Member

alxhub commented Apr 19, 2024

This PR was merged into the repository by commit 164dde4.

@alxhub alxhub closed this in 164dde4 Apr 19, 2024
@alan-agius4 alan-agius4 deleted the migration-clean branch April 19, 2024 13:35
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 20, 2024
@thePunderWoman
Copy link
Contributor

This ended up inadvertently removing all of the control flow migration's unit tests.

@alan-agius4
Copy link
Contributor Author

@thePunderWoman, I opened a PR to re-add these #56130

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update`/`ng generate` migrations target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants