feat(core): Add build target for jsaction contract binary.#55319
Closed
iteriani wants to merge 1 commit intoangular:mainfrom
Closed
feat(core): Add build target for jsaction contract binary.#55319iteriani wants to merge 1 commit intoangular:mainfrom
iteriani wants to merge 1 commit intoangular:mainfrom
Conversation
704856e to
e8441e2
Compare
Right now this binary sits at 9.5kb. Additional changes to the library will be done to reduce the binary size, such as converting event_type from an enum to an object, and other code size reductions.
e8441e2 to
2bc852f
Compare
tbondwilkinson
approved these changes
Apr 12, 2024
Contributor
Author
|
TGP not needed since this doesn't sync into g3 |
thePunderWoman
approved these changes
Apr 15, 2024
Member
|
TESTED=passing TGP |
Member
|
This PR was merged into the repository by commit bce5e23. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information