docs(router): deprecate RouterTestingModule#54466
Closed
atscott wants to merge 1 commit intoangular:mainfrom
Closed
docs(router): deprecate RouterTestingModule#54466atscott wants to merge 1 commit intoangular:mainfrom
atscott wants to merge 1 commit intoangular:mainfrom
Conversation
AndrewKushnir
approved these changes
Feb 16, 2024
Contributor
|
nit: should we change the commit message to |
df547b1 to
de2c281
Compare
Contributor
Author
Updated to |
Deprecate `RouterTestingModule` as it is no longer needed or useful and is not actively maintained. fixes angular#54461
de2c281 to
96b46fc
Compare
AndrewKushnir
approved these changes
Feb 16, 2024
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
pkozlowski-opensource
approved these changes
Feb 19, 2024
Member
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
sonukapoor
approved these changes
Feb 20, 2024
Member
|
This PR was merged into the repository by commit a9741e6. |
Contributor
|
@atscott it looks like we didn't include the "DEPRECATED" section into the commit message (thus it will not show up in the change log). Should we create an additional commit? |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecate
RouterTestingModuleas it is no longer needed or useful and is not actively maintained.fixes #54461