feat(compiler-cli): enable dom binding type checking by default#54098
Closed
devversion wants to merge 9 commits intoangular:mainfrom
Closed
feat(compiler-cli): enable dom binding type checking by default#54098devversion wants to merge 9 commits intoangular:mainfrom
devversion wants to merge 9 commits intoangular:mainfrom
Conversation
ea9eb29 to
4e7b40e
Compare
Currently Angular only validates that elements are existing as per our runtime DOM schema. Additionally, we validate that non-directive input bindings are valid according to the schema. We **never** validate whether the value of the expression is compatible with the targeted DOM property. This commit ensures this is happening by default with `strictTemplates` enabled. The reason why this came up more prominently at this point: - Users will adopt signal inputs and might forget invoking the signal, while Angular will never complain that e.g. `[id]="bla"` should actually be `[id]="bla()"` due to unsatisfied type assignability. There is old context on why we did not enable this by default in the past: angular#32171. It's worth seeing if that is still the case, or at least working towards flipping this default.
4e7b40e to
71e6939
Compare
14 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently Angular only validates that elements are existing as per our runtime DOM schema.
Additionally, we validate that non-directive input bindings are valid according to the schema.
We never validate whether the value of the expression is compatible with the targeted
DOM property. This commit ensures this is happening by default with
strictTemplatesenabled.The reason why this came up more prominently at this point:
[id]="bla"should actually be[id]="bla()"due to unsatisfied type assignability.There is old context on why we did not enable this by default in the past: #32171.
It's worth seeing if that is still the case, or at least working towards flipping this default.