test: fix and re-enable partial compliance linking tests#51620
Closed
devversion wants to merge 2 commits intoangular:mainfrom
Closed
test: fix and re-enable partial compliance linking tests#51620devversion wants to merge 2 commits intoangular:mainfrom
devversion wants to merge 2 commits intoangular:mainfrom
Conversation
Fixes and re-enables the partial compliance tests that weren't running for a while after being disabled in: angular#49914
4dd61df to
1a24a5d
Compare
The linker tests weren't running in a while-see previous commit. Due to this the recently introduced defer compliance tests are not fully compatible with linking. This commit disables two of these tests- all others work.
Member
Author
|
There are many source map failures: https://gist.github.com/devversion/993e2c0eee657629185dee91365bd7a2 |
Member
Author
|
Closing as there is a tracking issue and I will enable these tests without mapper assertions in the signal inputs PR |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes and re-enables the partial compliance tests that weren't running for a while after being disabled in:
#49914
There are two failurres-sounds like the lazy dependency functions are not properly generated/tracked with partial compilation output