Skip to content

refactor(forms): Add a test that uses ControlConfig with a non-static validator. #49693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dylhunn wants to merge 1 commit into from
Closed

refactor(forms): Add a test that uses ControlConfig with a non-static validator. #49693

dylhunn wants to merge 1 commit into from

Conversation

@dylhunn
Copy link
Contributor

@dylhunn dylhunn commented Apr 3, 2023 •
edited
Loading

Previously, this PR cleaned up a bug introduced by #48679. However, since that PR needed to be rolled back, this PR now just checks in the test, to prevent that issue from re-occurring in the future.

@dylhunn dylhunn added type: bug/fix action: review The PR is still awaiting reviews from at least one requested reviewer area: forms target: major This PR is targeted for the next major release forms: strictly typed labels Apr 3, 2023
@ngbot ngbot bot added this to the Backlog milestone Apr 3, 2023
@dylhunn
Copy link
Contributor Author

dylhunn commented Apr 3, 2023 •
edited
Loading

caretaker note: tap presubmit looks good modulo flakes.

@dylhunn dylhunn marked this pull request as ready for review April 3, 2023 21:57
@dylhunn dylhunn requested a review from AndrewKushnir April 3, 2023 21:58
@dylhunn dylhunn force-pushed the fix-exclude-validatorfn-from-control-config branch from 203d39f to e4fe1ad Compare April 3, 2023 21:59
@JeanMeche
Copy link
Member

JeanMeche commented Apr 3, 2023

Good catch, PermissiveControlConfig is really issue-prone. 👍

@dylhunn
Copy link
Contributor Author

dylhunn commented Apr 4, 2023 •
edited
Loading

Running a TGP on this fix: https://test.corp.google.com/OCL:521568566:BASE:521658659:1680585486732:7ca0e1d9
Rerun: https://fusion2.corp.google.com/presubmit/tap/521568566/OCL:521568566:BASE:521785342:1680625839081:39e13b0/targets

@dylhunn dylhunn removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 4, 2023
@dylhunn dylhunn mentioned this pull request Apr 4, 2023
Closed
4 tasks
@dylhunn
refactor(forms): Add a test that uses ControlConfig with a non-static…
b18dd0c 
… validator.

Previously, this PR cleaned up a bug introduced by angular#48679. However, since that PR needed to be rolled back, this PR now just checks in the test, to prevent that issue from re-occurring in the future.
@dylhunn dylhunn changed the title fix(forms): Exclude ValidatorFn from the inferred ControlConfig type refactor(forms): Add a test that uses ControlConfig with a non-static validator. Apr 4, 2023
@dylhunn dylhunn force-pushed the fix-exclude-validatorfn-from-control-config branch from e4fe1ad to b18dd0c Compare April 4, 2023 23:25
@dylhunn dylhunn added the action: merge The PR is ready for merge by the caretaker label Apr 4, 2023
@dylhunn
Copy link
Contributor Author

dylhunn commented Apr 5, 2023

This PR was merged into the repository by commit 136ffbc.

@dylhunn dylhunn closed this in 136ffbc Apr 5, 2023
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented May 6, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: forms forms: strictly typed target: major This PR is targeted for the next major release type: bug/fix

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@dylhunn @JeanMeche @AndrewKushnir