Skip to content

Conversation

@JeanMeche
Copy link
Member

BrowserTransferStateModule was deprecated in v14.1 and is empty. It can be removed.

To ensure a smooth deprecation, a migration schematic is provided.

PR Type

  • Feature

Does this PR introduce a breaking change?

  • Yes

`BrowserTransferStateModule` was deprecated in v14.1 and is empty. It can be removed.
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Apr 2, 2023
@JeanMeche JeanMeche force-pushed the chore/browser-transfer-state-module branch from c479cb1 to 014b094 Compare April 2, 2023 23:58
This commit provides a migration schematic to remove the usage of the now useless `BrowserTransferStateModule`
@JeanMeche JeanMeche force-pushed the chore/browser-transfer-state-module branch from 014b094 to 49ad49a Compare April 3, 2023 00:34
@JeanMeche JeanMeche marked this pull request as ready for review April 3, 2023 00:57
@pullapprove pullapprove bot requested review from AndrewKushnir and crisbeto April 3, 2023 00:58
@alan-agius4 alan-agius4 added this to the v16-candidates milestone Apr 3, 2023
@ngbot ngbot bot removed this from the v16-candidates milestone Apr 3, 2023
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 3, 2023
@dylhunn dylhunn added the area: core Issues related to the framework runtime label Apr 4, 2023
@ngbot ngbot bot added this to the Backlog milestone Apr 4, 2023
@alan-agius4 alan-agius4 removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 5, 2023
@AndrewKushnir
Copy link
Contributor

@JeanMeche thanks a lot for creating this PR! We've reviewed the changes and we believe that the schematic might be omitted in this case. To ensue that we land this change in time before the v16 feature freeze (which happens today), we've created a new PR where we cherry-picked your commit that removes the symbol: #49718. We made sure that you are retained as an author of the commit to acknowledge your contribution. Thanks again for your help!

@JeanMeche JeanMeche deleted the chore/browser-transfer-state-module branch April 6, 2023 09:29
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: core Issues related to the framework runtime detected: feature PR contains a feature commit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants