feat(language-service): support to fix invalid banana in box#47393
Closed
ivanwonder wants to merge 1 commit intoangular:mainfrom
Closed
feat(language-service): support to fix invalid banana in box#47393ivanwonder wants to merge 1 commit intoangular:mainfrom
ivanwonder wants to merge 1 commit intoangular:mainfrom
Conversation
07cc6a0 to
c3e4bfa
Compare
Contributor
Author
c3e4bfa to
9e7497c
Compare
Jeriko100
approved these changes
Sep 17, 2022
Contributor
|
Sorry, didn't see this. I'll review tomorrow morning. |
Contributor
Author
|
// cc @atscott |
atscott
approved these changes
Sep 22, 2022
packages/language-service/src/codefixes/fix_invalid_banana_in_box.ts
Outdated
Show resolved
Hide resolved
packages/language-service/src/codefixes/fix_invalid_banana_in_box.ts
Outdated
Show resolved
Hide resolved
packages/language-service/src/codefixes/fix_invalid_banana_in_box.ts
Outdated
Show resolved
Hide resolved
packages/language-service/src/codefixes/fix_invalid_banana_in_box.ts
Outdated
Show resolved
Hide resolved
dylhunn
approved these changes
Sep 23, 2022
Contributor
dylhunn
left a comment
There was a problem hiding this comment.
reviewed-for: language-service
Contributor
|
Looks like Andrew beat me to it. Thanks for implementing this :) |
7c30df6 to
f47df65
Compare
The Angular compiler will report the invalid banana in box, this code fixes will try to fix the error and all the same errors in the selected file. Fixes angular#44941
f47df65 to
e89c609
Compare
atscott
approved these changes
Sep 26, 2022
Member
|
This PR was merged into the repository by commit e7ee53c. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Angular compiler will report the invalid banana in box, this code fixes will try to fix the error and all the same errors in the selected file.
fixes #44941
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information