fix(zone.js): Fix ConsoleTask interface typo#47090
Closed
victorporof wants to merge 1 commit intoangular:mainfrom
Closed
fix(zone.js): Fix ConsoleTask interface typo#47090victorporof wants to merge 1 commit intoangular:mainfrom
victorporof wants to merge 1 commit intoangular:mainfrom
Conversation
Signed-off-by: Victor Porof <victorporof@chromium.org>
AndrewKushnir
approved these changes
Aug 9, 2022
Contributor
|
Merge-assistance: low risk change, no additional reviews are required, we can proceed with the merge. |
Contributor
|
@victorprof this has merge conflicts with the patch branch. If you'd like this in patch, please create a patch port rebase, thanks! |
Contributor
|
This PR was merged into the repository by commit 91954cf. |
Contributor
Author
Is this still needed? |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Victor Porof victorporof@chromium.org
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
This PR updates a TypeScript interface.
What is the current behavior?
ConsoleTask::runis typed as returningvoid.What is the new behavior?
ConsoleTask::runis typed returning the same value from invoking the function that was passed in as an argument.Does this PR introduce a breaking change?
Other information
According to the V8 implementation, the Async Stack Tagging API's task
runfunction is transparent and equivalent to changingf()totask.run(f). The return value offwon't be lost. This PR updates the interface to reflect that.