feat(platform-browser): add isEmpty method to the TransferState class#46915
Closed
AndrewKushnir wants to merge 1 commit intoangular:mainfrom
Closed
feat(platform-browser): add isEmpty method to the TransferState class#46915AndrewKushnir wants to merge 1 commit intoangular:mainfrom
isEmpty method to the TransferState class#46915AndrewKushnir wants to merge 1 commit intoangular:mainfrom
Conversation
CaerusKaru
approved these changes
Jul 20, 2022
alfaproject
reviewed
Jul 20, 2022
atscott
approved these changes
Jul 20, 2022
Contributor
atscott
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
alan-agius4
reviewed
Jul 21, 2022
alan-agius4
approved these changes
Jul 21, 2022
…lass This commit adds the `isEmpty` method to the `TransferState` class to make it possible to check whether the state is empty or not. This is helpful in situations when the `TransferState` should be serialized and the content is transferred to the client (if the state is empty - certain operations can be omitted).
5470ca7 to
ee08fbc
Compare
Contributor
Author
alxhub
approved these changes
Jul 22, 2022
Member
alxhub
left a comment
There was a problem hiding this comment.
Reviewed-for: fw-core, integration-tests, public-api
We really need fewer approval groups.
Member
|
This PR was merged into the repository by commit 07606e3. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds the
isEmptymethod to theTransferStateclass to make it possible to check whether the state is empty or not. This is helpful in situations when theTransferStateshould be serialized and the content is transferred to the client (if the state is empty - certain operations can be omitted).PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?