fix(zone.js): cancel tasks only when they are scheduled or running#46435
Closed
arturovt wants to merge 1 commit intoangular:mainfrom
Closed
fix(zone.js): cancel tasks only when they are scheduled or running#46435arturovt wants to merge 1 commit intoangular:mainfrom
arturovt wants to merge 1 commit intoangular:mainfrom
Conversation
a9a1fbf to
545a2a9
Compare
JiaLiPassion
approved these changes
Sep 10, 2022
Contributor
JiaLiPassion
left a comment
There was a problem hiding this comment.
Sorry for the late response, LGTM!
packages/zone.js/lib/zone.ts
Outdated
There was a problem hiding this comment.
nit: this comment would be better next to a test case, IMO
Currently, there's no check if the task (that is being canceled) has the right state. Only `scheduled` and `running` tasks can be canceled. If the task has a non-appropriate state, then an error will be thrown. Cancelation should not throw an error on an already canceled task, e.g. `clearTimeout` does not throw errors when it's called multiple times on the same timer. PR Close angular#45711
545a2a9 to
25f22c2
Compare
Contributor
|
TGP is green |
Contributor
|
This PR was merged into the repository by commit b618b5a. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there's no check if the task (that is being canceled) has the right state.
Only
scheduledandrunningtasks can be canceled. If the task has a non-appropriatestate, then an error will be thrown. Cancelation should not throw an error on an already
canceled task, e.g.
clearTimeoutdoes not throw errors when it's called multiple timeson the same timer.
Issue Number: #45711
Does this PR introduce a breaking change?