Skip to content

refactor(common): move LCP image observer to a separate file#46295

Merged
pkozlowski-opensource merged 1 commit intoangular:image-directivefrom
AndrewKushnir:move_lcp_observer
Jun 8, 2022
Merged

refactor(common): move LCP image observer to a separate file#46295
pkozlowski-opensource merged 1 commit intoangular:image-directivefrom
AndrewKushnir:move_lcp_observer

Conversation

@AndrewKushnir
Copy link
Contributor

This is a small refactoring to extract the LCP image observer to a separate file, similar to the preconnect link checker class location.

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

Does this PR introduce a breaking change?

  • Yes
  • No

This is a small refactoring to extract the LCP image observer to a separate file, similar to the preconnect link checker class location.
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer area: common Issues related to APIs in the @angular/common package PullApprove: disable target: feature This PR is targeted for a feature branch (outside of main and semver branches) labels Jun 8, 2022
@ngbot ngbot bot modified the milestone: Backlog Jun 8, 2022
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkozlowski-opensource pkozlowski-opensource merged commit 850d972 into angular:image-directive Jun 8, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer area: common Issues related to APIs in the @angular/common package PullApprove: disable target: feature This PR is targeted for a feature branch (outside of main and semver branches)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants