Skip to content

Conversation

@atscott
Copy link
Contributor

@atscott atscott commented Apr 22, 2022

BREAKING CHANGE:
initialNavigation: 'enabled' was deprecated in v11 and is replaced by
initialNavigation: 'enabledBlocking'.

@atscott atscott added area: router target: major This PR is targeted for the next major release labels Apr 22, 2022
@atscott atscott requested a review from CaerusKaru April 22, 2022 20:43
@ngbot ngbot bot modified the milestone: Backlog Apr 22, 2022
@atscott atscott force-pushed the removeEnabledInitialNv branch from ac0e8c7 to c05f4a2 Compare April 22, 2022 20:48
@atscott atscott force-pushed the removeEnabledInitialNv branch from c05f4a2 to f10520f Compare April 22, 2022 20:54
Copy link
Member

@CaerusKaru CaerusKaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

BREAKING CHANGE:
`initialNavigation: 'enabled'` was deprecated in v11 and is replaced by
`initialNavigation: 'enabledBlocking'`.
@atscott atscott force-pushed the removeEnabledInitialNv branch from f10520f to 59ad136 Compare April 22, 2022 21:31
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@atscott atscott modified the milestones: Backlog, v14-candidates Apr 25, 2022
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

Copy link
Contributor

@dylhunn dylhunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@dylhunn dylhunn added the action: merge The PR is ready for merge by the caretaker label Apr 28, 2022
@dylhunn
Copy link
Contributor

dylhunn commented Apr 28, 2022

This PR was merged into the repository by commit d4fc12f.

@dylhunn dylhunn closed this in d4fc12f Apr 28, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: router target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants